-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] Adding Queue for the ble events and removing the semaphore #35522
[Silabs] Adding Queue for the ble events and removing the semaphore #35522
Conversation
Review changes with SemanticDiff. |
PR #35522: Size comparison from cbd15a1 to 73b5433 Full report (74 builds for bl602, bl702, bl702l, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #35522: Size comparison from cbd15a1 to bc0a9a1 Full report (12 builds for nrfconnect, nxp, qpg, stm32, tizen)
|
PR #35522: Size comparison from cbd15a1 to 52219f0 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #35522: Size comparison from add0bf1 to 9f81638 Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #35522: Size comparison from add0bf1 to 28d7219 Increases above 0.2%:
Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #35522: Size comparison from add0bf1 to ef83f1b Increases above 0.2%:
Full report (78 builds for bl602, bl702, bl702l, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #35522: Size comparison from c9daf0c to 81375dc Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
…roject-chip#35522) * adding queue logic to the semaphore * removing the extern keyword for the queue * cleanup of ble defines and variables * Restyled by whitespace * restyling the PR * removing the temp change * restyling the PR * reverting BLEManagerImpl.h to fix * fixing the build for the 91x ncp * addressing review comments * Restyled by whitespace * Restyled by clang-format * modifying the file to have classes * restyling the PR * Restyled by whitespace * cleanup the unused from the .h file and fixing build * Addressing review comments --------- Co-authored-by: Restyled.io <commits@restyled.io>
Problem:
The Ble on the Rs911x devices was using bitmaps for the events and having semaphores between source files via extern keywords
Fix
Moving to queue based implementation of the ble events which will not poll everytime and will be done in the FIFO fashion. Sending the details via the structure in queue
Testing
Tested locally with 917 SoC